ajaxmin Issue Tracker Rss Feed

Commented Issue: After upgrading to 4.91 MSBUILD task fails [19719]

ronlo — Thu, 23 May 2013 22:30:35 GMT

I've just upgraded to the latest 4.91 version, and my minification MSBuild task fails. I'm using the manifest task AjaxManifestTask. Changed nothing in my .targets and .ajaxmin files, but my build fails saying

error : Required manifest <input> file does not exist

Worked fine on all versions before 4.91. Tested on 4.90 - works fine. Fails only on 4.91.
Comments: ** Comment from web user: ronlo **

Sorry; just had time today to take a look at this. Apologies.

I think I found the problem: first off, the manifest task was totally ignoring the InputFolders property, so every relative path in the manifest was relative to the manifest, which is probably why you were getting the errors. But then I also tweaked the error messages to include the path it couldn't find (kinda helps debugging); and the new Clean target needed to not validate the inputs because it doesn't care (it just wants to delete all the outputs anyway).

Will ship with 4.92.

Commented Issue: Exclude doesn't work [19653]

robertdunaway — Thu, 23 May 2013 18:19:41 GMT

I've tried on multiple occasions to update my minify from 4.0 to 4.8x and each time I do it I get hundreds of new errors. These errors come from files that are not supposed to be minified.

I excluded these files when implementing the 4.0 version and everything works as it should.

Now, with the newest minifier those exclusions are ignored and minifier tries to minify everything.

I've had to back our the new version and go back to the older 4.0 version.

I have to move on with my code migration without this particular upgrade but in the future I would love to revisit the ajax minifier.
Comments: ** Comment from web user: robertdunaway **

That is exactly what I needed. I'm sorry it took so long to get back to this but I was on a tight schedule. I just implemented what you suggested and it ran like a dream.

Thanks,
Bob

Commented Issue: Unicode Issues [19423]

ronlo — Sat, 18 May 2013 00:47:22 GMT

I used a older version of AjaxMin and when I minify the file Unicode characters are encoded properly

For example Bokade besök will be converted to Bokade bes\u00f6k

But with the latest update it doesn’t work. Following is the command I ran

```
ajaxmin "C:\Users\jeyakumaran_m\Documents\Rahmqvist\Source\JQueryMobile\lng\LANG.js" -o "C:\Users\jeyakumaran_m\Documents\Rahmqvist\Source\JQueryMobile\lng\LANG.min.js" -clobber
```

I even tried this

```
ajaxmin "C:\Users\jeyakumaran_m\Documents\Rahmqvist\Source\JQueryMobile\lng\LANG.js" -o "C:\Users\jeyakumaran_m\Documents\Rahmqvist\Source\JQueryMobile\lng\LANG.min.js" -clobber -enc:in utf-8 -enc:out utf-8
```

But no luck. Has anyone had the same problem??
Comments: ** Comment from web user: ronlo **

Actually, StringWriter doesn't seem to let you change the encoding property or set the fallback. If you define this function, it writes the given JS string to memory using the ASCII encoding with the JSEncoderFallback to a memory stream, then reads it back into a string:
```
private static string GetAsciiEncodedOutput(string minified)
{
var encoder = (Encoding)Encoding.ASCII.Clone();
encoder.EncoderFallback = new Microsoft.Ajax.Utilities.JSEncoderFallback();
var encodedBytes = encoder.GetBytes(minified);

using (var memoryStream = new MemoryStream(encodedBytes))
{
using (var reader = new StreamReader(memoryStream))
{
return reader.ReadToEnd();
}
}
}
```

I tried a program like this and it worked:
```
static void Main(string[] args)
{
var parser = new Microsoft.Ajax.Utilities.JSParser("alert('你好！')");
var block = parser.Parse(null);
var minified = block.ToCode();

System.Diagnostics.Debug.WriteLine(minified);
System.Diagnostics.Debug.WriteLine(GetAsciiEncodedOutput(minified));
}
```

The output was:
```
alert("你好！")
alert("\u4f60\u597d\uff01")
```

Commented Issue: Unicode Issues [19423]

ronlo — Fri, 17 May 2013 23:44:55 GMT

Ah, okay. So you get the string back as a UNICODE string since .NET keeps all strings as UNICODE. What you need to us is use the handy-dandy JSEncoderFallback class.

http://ajaxmin.codeplex.com/wikipage?title=EncoderFallbacks

If you're writing to a file, just follow the directions on that page. If you're not writing to a file, I would suggest setting up a StringWriter using the fallback class with a StringBuilder class behind it, write the minified results to the StringWriter, then get the results from the StringBuilder.

Commented Issue: Unicode Issues [19423]

wonmanfactory — Fri, 17 May 2013 22:41:07 GMT

If i am using the dll. what should I do?

Commented Issue: After upgrading to 4.91 MSBUILD task fails [19719]

creage — Thu, 16 May 2013 18:08:59 GMT

It doesn't tell which one, it only points to a row number where it fails - row #122 of .targets file

[wzc.targets](https://www.dropbox.com/s/31bd9b6ztux7n0e/wzc.targets)
[wzc.ajaxmin](https://www.dropbox.com/s/bopz3bu7lpxrr33/wzc.ajaxmin)

I didn't modify my files, so currently they contain a lot of build stuff you can ignore :)

Hope it helps, thanks.

Commented Issue: After upgrading to 4.91 MSBUILD task fails [19719]

ronlo — Thu, 16 May 2013 14:51:17 GMT

I'll take a look. Any chance of letting me know what your manifest looks like? Does it tell you which file doesn't exists, and does it actually exist (I'm assuming that's the case, but I just want to be sure)?

Closed Issue: Source Maps - JSON-format [18743]

andrewdavey — Thu, 16 May 2013 11:31:57 GMT

I see support for Script# source maps in AjaxMin. Is anyone working on adding support for the JSON-based source map format?

Details of the format here:
https://docs.google.com/a/ooyala.com/document/d/1U1RGAehQwRypUTovF1KRlpiOFze0b-_2gc6fAH0KY0k/edit?pli=1#

Closed Issue: AjaxMin Build Task should respect file times [18766]

ronlo — Thu, 16 May 2013 11:31:56 GMT

When building a project using the AjaxMin build task, the task should check the input and output file times and not perform any minification operation if the output file is newer than all the input file(s).

Closed Issue: Unable to get build tasks working. [18900]

ronlo — Thu, 16 May 2013 11:31:55 GMT

I'm not sure what I'm doing wrong, but I can't things working. I'm trying to do the "Using the Ajax Minifier Manifest Task" setup at - http://ajaxmin.codeplex.com/wikipage?title=ManifestTask

When I setup it up I get an error when building that says that it can't find - "AjaxMinManifestTask". Am I doing something wrong?

I installed via nuget.

Thanks!

Closed Issue: -pretty doesn't exclude certain debug code. [18924]

IanSul — Thu, 16 May 2013 11:31:54 GMT

AjaxMin invoked with the -pretty option, and "-JS -evals:immediate -clobber:true" produces a file that retains ///DEBUG ... ///ENDDEBUG blocksRunAjaxMin.exe -pretty -JS -evals:immediate -clobber:true ajmtest_min.js -o ajmtest_min_pretty.jsAgainst the attached ajmtest_min.js file, you will see that ajmtest_min_pretty.js still contains the code inside the ///DEBUG block.If you run AjaxMin without the -pretty flag, notice the ///DEBUG block is gone in the resulting ajmtest_min_cmp.js fileAjaxMin.exe -pretty -JS -evals:immediate -clobber:true ajmtest_min.js -o ajmtest_min_cmp.jsAdditionally the $Debug.assert() block is also in the "pretty" output.

Closed Issue: Removing an input from the .ajaxmin doesn't cause a rebuild [19190]

Zhaph — Thu, 16 May 2013 11:31:53 GMT

Version: 4.78.4724.23869 - via NuGet.
Visual Studio 2010

We're running Ajax Minifier as a build task in our project configured with an .ajaxmin manifest file.

If we remove an "input" element from an output, the resulting output file is skipped as (I assume) none of the inputs have changed since the last build.

I think it would be better if the task were to also check the modified timestamp of the manifest file and if that has changed more recently than the files referenced, it should rebuild all outputs.

A workaround is obviously to delete the output file and then do a build.

Closed Issue: StripDebugStatements is not working [19296]

carlosjln — Thu, 16 May 2013 11:31:53 GMT

Hi,

This is simple... on the previous version it was working like a charm, i did a nuget update package and now the code between ///#DEBUG and ///#ENDDEBUG is gone even when StripDebugStatements is set to false.

I've debuged the code to make sure its set to false and did evaluations on the JS (and the code is there) but later evaluate the MinifyJavaScript output and its gone. What might that be?

Thanks in advance.

(Update)

Maybe this had something to do with it http://ajaxmin.codeplex.com/releases/view/98819

(Update)
In deed, that change affected, i managed to install the version prior that update via console

Install-Package AjaxMin -Version 4.77.4723.25304

And the comments worked just fine, maybe some unit tests could be added to prevent that bug to happen again.

Closed Issue: Exec() troubles [19309]

ronlo — Thu, 16 May 2013 11:31:53 GMT

Hi,
I have this issue working with js function exec().
Before minification all works correct, but after go to infinitive loop or to null.
Here a couple of example.
This function minimized send the while condition to infinite:
(function () {
var match,
pl = /\+/g, // Regex for replacing addition symbol with a space
search = /([^&=]+)=?([^&]*)/g,
decode = function (s) { return decodeURIComponent(s.replace(pl, " ")); },
query = $.cookie('VISIT');

while (match = search.exec(query))
urlParams[decode(match[1])] = decode(match[2]);
})();
This one,
f = /MSIE (\d+)/.exec(navigator.userAgent)[1];
give a null so the result is f = (null)[1].

Thanks

Closed Issue: Important comments aren't always preserved [19416]

ronlo — Thu, 16 May 2013 11:31:52 GMT

Looks like important comments need to be at the document level to be preserved:

```
Something.init(
/*!This is an important comment */
);
/*!This is an important comment too! */
function Dennis() {
/*!So is this */
}
```

Gets minified to:

```
function Dennis(){}Something.init();
/*!This is an important comment too! */
```

Closed Issue: Using a shift and enabling RemoveUnneededCode generates a infinite loop. [19440]

ronlo — Thu, 16 May 2013 11:31:52 GMT

I got the following code:
```
var getTransformProperty = function (element) {
var properties = [
'transform',
'WebkitTransform',
'msTransform',
'MozTransform',
'OTransform'
];
var p;
while (p = properties.shift()) {
if (typeof element.style[p] != 'undefined') {
return p;
}
}
return false;
};
```
When I minify this code with RemoveUnneededCode set to true it generates this:
```
var getTransformProperty=function(n){
for (
var t;
t=["transform","WebkitTransform","msTransform","MozTransform","OTransform"].shift();
) if(typeof n.style[t]!="undefined") return t; return!1 }
```
The minifier placed the variable straight before the shirt() method which means now it became an infinite loop.

Closed Issue: AjaxMinTask not working as expected [19459]

ronlo — Thu, 16 May 2013 11:31:52 GMT

I am using AjaxMinTask and ajaxmin files from a .NET project in VS2010 to concatenate and compress both css and js files.

1. First problem is that the js code is broken once minified. I am using 14 files as input, JQuery, Knockout, YUI, etc., as well as my own code. One thing I am doing though is that I am using the already minified versions of the vendors' files listed above. Not sure if this is allowed but it would be handy (if not, why?). I have tried to use the following switches to no evail:

–global:YUI,JQuery,$,ko -evals:safeall -fnames:keep<

I am doing many Ajax calls and I wonder if this is not what gets broken (I saw there was a problem with that; not sure if it's been fixed).

2. Another problem is that the output files do not get overwritten with every build even though I use the "-clobber:true" switch. If not resolved, this problem would be definitely a show stopper (i.e. find another solution) as we do automatic builds on a build server and need to be sure the files will be renewed every time.

Thanks, Yves

Closed Issue: default "unused:remove" can break ref parameters [19559]

ronlo — Thu, 16 May 2013 11:31:52 GMT

This code:
```
var outRef = { };
for (var j=0; j<count; j++) {
this.doSomething( array[j], outRef );
}
```

Is optimized to:
```
for (var j=0; j<count; j++) {
this.doSomething( array[j], { } );
}
```

The outRef parameter needs to be kept because each iteration of the loop adds fields / values to the outRef param that is used by successive calls in the loop;

I believe this problem only affects local variables initialized to empty object, where the local variable appears to only be used once and is not the return value. However, because it is in a loop, it is used multiple times, and needs to be kept as a ref parameter.

We can change the minification option "unused" to "keep", to work around this issue. However, the default being "remove", I believe this is a bug that should be fixed.

Closed Issue: Error with IE and Source Maps [19632]

ronlo — Thu, 16 May 2013 11:31:51 GMT

When debugging in VS, every time a js with with a source maps loads it throws an error which brings me back into Visual Studio. jQuery fixed the issue by adding a comment tag so that IE will ignore the tag:

http://bugs.jquery.com/ticket/13274

Closed Issue: New versions of the Microsoft Ajax Minifier not published in NuGet Gallery [19635]

Taritsyn — Thu, 16 May 2013 11:31:51 GMT

Now in NuGet Gallery most recent version of the Microsoft Ajax Minifier is 4.86.