Microsoft Ajax Minifier

Commented Unassigned: JS: Option for delimiting files when concatenating [19862]

ronlo — Mon, 17 Jun 2013 20:29:56 GMT

I'd like an option to insert a delimiting character between each concatenated JS file. For example, a semicolon

My reasoning for this is to deal with this scenario

**file1.js**

function myFunction() {
// code here
}

**file2.js**

(function() {
// code here
}())

If these are concatenated in the order file1.js, file2.js we will get the following output:

function myFunction(){}(function() {}())

We will hit issues where the JS is interpreted as file2's contents being passed as args to `myFunction` (i.e. an immediately executing function).

Whilst I could modify the sources, usually I encounter this with 3rd party scripts and I'd rather not touch them so that I can pull in upstream changes regularly.

An option to add a delimeter between each file would cleanly solve this issue. It wouldn't have to be smart enough to detect if a delimiter already exists, as >1 delimiter would not cause issues.

Thanks
Comments: ** Comment from web user: ronlo **

Poor wording on my part; it was fixed sometime _after_ 4.79. Somewhere in the 4.84 range or something.

New Post: Source Maps from multiple files using AjaxMin.dll

ronlo — Mon, 17 Jun 2013 16:54:48 GMT

I believe I have this fixed in the 4.94 release now. When I process a.js, b.js, and c.js with separate calls to MinifyJavaScript as described above, the generated source map ends up with these mappings:

AAAAA   (0,0,0,0,0)     min:(1,1)       src: (1,1)       name:'define'          a.js
MAAM    (6,0,0,6)       min:(1,7)       src: (1,7)
CAAC    (1,0,0,1)       min:(1,8)       src: (1,8)
MAAD    (6,0,0,-1)      min:(1,14)      src: (1,7)
CAAQ    (1,0,0,8)       min:(1,15)      src: (1,15)
CCAdA   (1,1,0,-14,0)   min:(1,16)      src: (1,1)       name:'define'          b.js
MAAM    (6,0,0,6)       min:(1,22)      src: (1,7)
CAAC    (1,0,0,1)       min:(1,23)      src: (1,8)
KAAD    (5,0,0,-1)      min:(1,28)      src: (1,7)
CAAO    (1,0,0,7)       min:(1,29)      src: (1,14)
CAEbC   (1,0,2,-13,1)   min:(1,30)      src: (3,1)       name:'console'
OAAOC   (7,0,0,7,1)     min:(1,37)      src: (3,8)       name:'log'
IAAI    (4,0,0,4)       min:(1,41)      src: (3,12)
CAAC    (1,0,0,1)       min:(1,42)      src: (3,13)
GAAD    (3,0,0,-1)      min:(1,45)      src: (3,12)
CAAK    (1,0,0,5)       min:(1,46)      src: (3,17)
CAEhBC  (1,0,2,-16,1)   min:(1,47)      src: (5,1)       name:'UUUUUU'
M       (6)             min:(1,53)
CCJAH   (1,1,-4,0,-3)   min:(1,54)      src: (1,1)       name:'define'          c.js
MAAM    (6,0,0,6)       min:(1,60)      src: (1,7)
CAAC    (1,0,0,1)       min:(1,61)      src: (1,8)
KAAD    (5,0,0,-1)      min:(1,66)      src: (1,7)
CAAO    (1,0,0,7)       min:(1,67)      src: (1,14)
CAEbA   (1,0,2,-13,0)   min:(1,68)      src: (3,1)       name:'define'
SAASA   (9,0,0,9,0)     min:(1,77)      src: (3,10)      name:'define'
MAAM    (6,0,0,6)       min:(1,83)      src: (3,16)
CAAA    (1,0,0,0)       min:(1,84)      src: (3,16)
CAAG    (1,0,0,3)       min:(1,85)      src: (3,19)

And gives the proper decoded location for the UUUUUU error (b.js, line 5).

Edited Unassigned: analyze files are hard to use for concatenated files [19791]

ronlo — Mon, 17 Jun 2013 16:51:08 GMT

I'm trying to consume an analyze XML file to help add context to a map file and I noticed that the various fields, e.g. srcLine, srcCol refer to the original unminned file, and there is no way to map those into the minned file. I see that it gets the minned symbol (e.g. min="rt") but even that's not a great help since I can't find a way to refence the minned symbol in tha map file.
Comments: ** Comment from web user: ronlo **

4.94 has been released; dstLine and dstCol attributes should now be available on elements in the XML analyze output. Let me know if this meets your needs so I can close the issue. Thanks!

Created Release: Microsoft Ajax Minifier 4.94 (Jun 17, 2013)

ronlo — Mon, 17 Jun 2013 16:49:46 GMT

add dstLine and dstCol attributes to the -Analyze output in XML mode.
un-combine leftover comma-separates expression statements after optimizations are complete so downstream tools don't stack-overflow on really deep comma trees.
add support for using a single source map generator instance with multiple runs of MinifyJavaScript, assuming that the results are concatenated to the same output file.

Released: Microsoft Ajax Minifier 4.94 (Jun 17, 2013)

Mon, 17 Jun 2013 16:49:46 GMT

add dstLine and dstCol attributes to the -Analyze output in XML mode.
un-combine leftover comma-separates expression statements after optimizations are complete so downstream tools don't stack-overflow on really deep comma trees.
add support for using a single source map generator instance with multiple runs of MinifyJavaScript, assuming that the results are concatenated to the same output file.

Commented Unassigned: JS: Option for delimiting files when concatenating [19862]

ronlo — Mon, 17 Jun 2013 16:35:30 GMT

Then please try the latest version. The proper separation of files has been fixed since 4.79.

Source code checked in, #101139

ronlo — Mon, 17 Jun 2013 16:25:23 GMT

Source map objects are stored in the settings object, so it's possible to use one source map for multiple runs of MinifyJavaScript (for example). So each run needs to tell the source map where it left off so the next run (if any) can properly adjust the output indexes passed to it.

Commented Unassigned: JS: Option for delimiting files when concatenating [19862]

WickyNilliams — Mon, 17 Jun 2013 15:55:39 GMT

Hi ronlo.

I'm using v4.79, using XML configuration. One detail that might be relevant: the offending files don't have a comment banner `/*! */` at the top of the file

Commented Unassigned: JS: Option for delimiting files when concatenating [19862]

ronlo — Mon, 17 Jun 2013 15:28:49 GMT

What version are you using? The EXE and build tasks already insert a newline and semicolon between files it concatenates - that functionality was added a few versions ago.

Created Unassigned: JS: Add option for delimiting files when concatenating [19862]

WickyNilliams — Mon, 17 Jun 2013 15:04:01 GMT

New Post: Source Maps from multiple files using AjaxMin.dll

whoknewDK — Sun, 16 Jun 2013 13:31:14 GMT

Yes, I have everything working fine using "///#SOURCE" in my project. Making it work by reusing the V3SourceMap object should just be for a cleaner interface and workflow (maybe the sport of it). Definitely not a high priority.

Your identification of the index being reset also kind of makes sense. Looking at the incorrect result though, the pattern actually seems to be correct. As far as I can see the only problem is that the offset is not relative to where the previous index ended.

If you want I can try and have a go at it?

Source code checked in, #101114

ronlo — Sun, 16 Jun 2013 10:37:01 GMT

Oops - should've checked in Chrome first to make sure the new syntax was being used there. Apparently not; I couldn't get a source map to load using the //# format. Backing out until I know there's more support for the spec change.

New Post: Source Maps from multiple files using AjaxMin.dll

ronlo — Sun, 16 Jun 2013 10:21:45 GMT

(ugh - typed a big long description and CodePlex failed to take it. At least I think it did. If there's a double-post, I apologize)

So I see the problem now. With the separate-MinifyJavaScript calls, the output visitor generating the map is being invoked separately for each file, and has no idea the output is being appended to previous output, so the "minified" code indexes start over at 1, which horks the file. I think I might be able to fix this, but I'm not really sure yet.

Good map file decode:

AAAAA   (0,0,0,0,0)     min:(1,1)       src: (1,1)       name:'define'          a.js
MAAM    (6,0,0,6)       min:(1,7)       src: (1,7)
CAAC    (1,0,0,1)       min:(1,8)       src: (1,8)
MAAD    (6,0,0,-1)      min:(1,14)      src: (1,7)
CAAQ    (1,0,0,8)       min:(1,15)      src: (1,15)
CCAdA   (1,1,0,-14,0)   min:(1,16)      src: (1,1)       name:'define'          b.js
MAAM    (6,0,0,6)       min:(1,22)      src: (1,7)
CAAC    (1,0,0,1)       min:(1,23)      src: (1,8)
KAAD    (5,0,0,-1)      min:(1,28)      src: (1,7)
CAAO    (1,0,0,7)       min:(1,29)      src: (1,14)
CAEbC   (1,0,2,-13,1)   min:(1,30)      src: (3,1)       name:'console'
OAAOC   (7,0,0,7,1)     min:(1,37)      src: (3,8)       name:'log'
IAAI    (4,0,0,4)       min:(1,41)      src: (3,12)
CAAC    (1,0,0,1)       min:(1,42)      src: (3,13)
GAAD    (3,0,0,-1)      min:(1,45)      src: (3,12)
CAAK    (1,0,0,5)       min:(1,46)      src: (3,17)
CAEhBC  (1,0,2,-16,1)   min:(1,47)      src: (5,1)       name:'UUUUUU'
MACA    (6,0,1,0)       min:(1,53)      src: (6,1)
CCLAH   (1,1,-5,0,-3)   min:(1,54)      src: (1,1)       name:'define'          c.js
MAAM    (6,0,0,6)       min:(1,60)      src: (1,7)
CAAC    (1,0,0,1)       min:(1,61)      src: (1,8)
KAAD    (5,0,0,-1)      min:(1,66)      src: (1,7)
CAAO    (1,0,0,7)       min:(1,67)      src: (1,14)
CAEbA   (1,0,2,-13,0)   min:(1,68)      src: (3,1)       name:'define'
SAASA   (9,0,0,9,0)     min:(1,77)      src: (3,10)      name:'define'
MAAM    (6,0,0,6)       min:(1,83)      src: (3,16)
CAAA    (1,0,0,0)       min:(1,84)      src: (3,16)
CAAG    (1,0,0,3)       min:(1,85)      src: (3,19)

Bad map file decode (notice the "min" values restarting at 1 for each file switch):

AAAAA   (0,0,0,0,0)     min:(1,1)       src: (1,1)       name:'define'          a.js
MAAM    (6,0,0,6)       min:(1,7)       src: (1,7)
CAAC    (1,0,0,1)       min:(1,8)       src: (1,8)
MAAD    (6,0,0,-1)      min:(1,14)      src: (1,7)
CAAQ    (1,0,0,8)       min:(1,15)      src: (1,15)
dCAdA   (-14,1,0,-14,0) min:(1,1)       src: (1,1)       name:'define'          b.js
MAAM    (6,0,0,6)       min:(1,7)       src: (1,7)
CAAC    (1,0,0,1)       min:(1,8)       src: (1,8)
KAAD    (5,0,0,-1)      min:(1,13)      src: (1,7)
CAAO    (1,0,0,7)       min:(1,14)      src: (1,14)
CAEbC   (1,0,2,-13,1)   min:(1,15)      src: (3,1)       name:'console'
OAAOC   (7,0,0,7,1)     min:(1,22)      src: (3,8)       name:'log'
IAAI    (4,0,0,4)       min:(1,26)      src: (3,12)
CAAC    (1,0,0,1)       min:(1,27)      src: (3,13)
GAAD    (3,0,0,-1)      min:(1,30)      src: (3,12)
CAAK    (1,0,0,5)       min:(1,31)      src: (3,17)
CAEhBC  (1,0,2,-16,1)   min:(1,32)      src: (5,1)       name:'UUUUUU'
M       (6)             min:(1,38)
rCCJAH  (-37,1,-4,0,-3) min:(1,1)       src: (1,1)       name:'define'          c.js
MAAM    (6,0,0,6)       min:(1,7)       src: (1,7)
CAAC    (1,0,0,1)       min:(1,8)       src: (1,8)
KAAD    (5,0,0,-1)      min:(1,13)      src: (1,7)
CAAO    (1,0,0,7)       min:(1,14)      src: (1,14)
CAEbA   (1,0,2,-13,0)   min:(1,15)      src: (3,1)       name:'define'
SAASA   (9,0,0,9,0)     min:(1,24)      src: (3,10)      name:'define'
MAAM    (6,0,0,6)       min:(1,30)      src: (3,16)
CAAA    (1,0,0,0)       min:(1,31)      src: (3,16)
CAAG    (1,0,0,3)       min:(1,32)      src: (3,19)

New Post: Source Maps from multiple files using AjaxMin.dll

ronlo — Sun, 16 Jun 2013 09:55:16 GMT

Yes, I'm seeing that too. Sorry; I should've tested this first in Chrome. So the command-line tool generates a map that works, but the DLL when sharing the same V3SymbolMap object and running MinifyJavaScript does not.
Okay, so I ran the command-line tool with the -reorder:no switch so the function declaration doesn't get moved to the very front of the combined.js:

ajaxmin a.js b.js c.js -o combined.js -map:v3 combined.js.map -reorder:no

Then I added the ReorderScopeDeclarartions=false flag to the CodeSettings object in my dll test app to match the command-line. (and went back to the proper a.js, b.js, c.js ordering of input files) The JS output by the two methods is identical:

define("jake");define("boo");console.log(123);UUUUUU;define("coo");function define(){}
/*
//@ sourceMappingURL=combined.js.map
*/

but the mapping is slightly different. The command-line mappings:

"mappings":"AAAAA,MAAM,CAAC,MAAD,CAAQ,CCAdA,MAAM,CAAC,KAAD,CAAO,CAEbC,OAAOC,IAAI,CAAC,GAAD,CAAK,CAEhBC,MACA,CCLAH,MAAM,CAAC,KAAD,CAAO,CAEbA,SAASA,MAAM,CAAA,CAAG",

and the dll mappings:

"mappings":"AAAAA,MAAM,CAAC,MAAD,CAAQ,dCAdA,MAAM,CAAC,KAAD,CAAO,CAEbC,OAAOC,IAAI,CAAC,GAAD,CAAK,CAEhBC,M,rCCJAH,MAAM,CAAC,KAAD,CAAO,CAEbA,SAASA,MAAM,CAAA,CAAG",

(map items #6, #18 and #19). Looking into why. And I'm assuming here that you've got a good work-around using the ///#SOURCE method, so this isn't a high priority.

New Post: Source Maps from multiple files using AjaxMin.dll

whoknewDK — Sat, 15 Jun 2013 21:41:24 GMT

So I finally got around to testing this out. As you correctly state, on the face of it the source map seems right. But it seems to be the case that errors are only correctly mapped when they are contained in the last file (in this case b.js).

If I delete the "UUUUUU" part and move into into a.js instead, then the error messages I receive claim that the error occurs in b.js at line 3.

I should note that I am simply validating the files by consuming them through Chrome using Developer tools.

Regarding my code; it essentially looks exactly like yours above except for "sourceMap.EndFile(outputWriter, "\r\n");". If you still find a discrepancy between your results and what I claim then I can post the actual code.

Source code checked in, #101093

ronlo — Fri, 14 Jun 2013 15:07:10 GMT

source maps spec has changed: sourceMappingURL comment needs to start with "//#" now, not the "//@" that can be misinterpreted as a conditional-compilation comment in IE.

Closed Issue: Unicode Issues [19423]

ronlo — Fri, 14 Jun 2013 10:46:51 GMT

I used a older version of AjaxMin and when I minify the file Unicode characters are encoded properly

For example Bokade besök will be converted to Bokade bes\u00f6k

But with the latest update it doesn’t work. Following is the command I ran

```
ajaxmin "C:\Users\jeyakumaran_m\Documents\Rahmqvist\Source\JQueryMobile\lng\LANG.js" -o "C:\Users\jeyakumaran_m\Documents\Rahmqvist\Source\JQueryMobile\lng\LANG.min.js" -clobber
```

I even tried this

```
ajaxmin "C:\Users\jeyakumaran_m\Documents\Rahmqvist\Source\JQueryMobile\lng\LANG.js" -o "C:\Users\jeyakumaran_m\Documents\Rahmqvist\Source\JQueryMobile\lng\LANG.min.js" -clobber -enc:in utf-8 -enc:out utf-8
```

But no luck. Has anyone had the same problem??

Reopened Issue: Unicode Issues [19423]

ronlo — Fri, 14 Jun 2013 10:46:12 GMT

Closed Issue: Unicode Issues [19423]

ronlo — Fri, 14 Jun 2013 10:46:08 GMT

Closed Issue: jquery-1.8.2 Improperly Minified, breaks AJAX calls [18721]

ronlo — Fri, 14 Jun 2013 10:45:18 GMT

Line 999 of jquery-1.8.2:
http://code.jquery.com/jquery-1.8.2.js

Reads:

(function add( args ) {

Line 1006 then calls this function:
add( arg );

Here's what AjaxMinifier produces on line 999 when processing this code with all minification options off:

(function(args){

This causes the later call to add(arg) to fail because the function add doesn't exist.

This code path is used in standard AJAX calls in jquery 1.8.2.

The code is also broken if you turn on more minification options - it's just easier to catch and explain with them off.